Add icons to Command Palette #10049

janfaracik · 2024-12-11T20:23:16Z

Medium-ish PR to add icons to the newly introduced Command Palette. This is one of the first refinements to search, with the intention of making search more useful and visual for users. Actions can override getSearchIcon() to add an icon, or if they implement IconSpec getSearchIcon() will use that by default.

Big thanks to @timja for help on this :)

Testing done

Icons show in the Command Palette
Bitmaps also show (e.g. user avatars)

Proposed changelog entries

Add icons to Command Palette

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

This reverts commit 24837ea.

…jenkins into add-icons-to-command-palette

core/src/main/java/hudson/model/Computer.java

timja · 2024-12-11T21:04:35Z

@janfaracik add the rfe changelog for a minor enhancement to changelog.

web-ui is just for filtering for people interested it doesn't do anything itself

jtnord · 2024-12-11T21:09:19Z

I guess this comment is relevant here.
Why is IconSpec javadoc not being updated if it is no longer just for Actions/ManagementLinks?

…jenkins into add-icons-to-command-palette

timja · 2024-12-11T21:12:35Z

I guess this comment is relevant here. Why is IconSpec javadoc not being updated if it is no longer just for Actions/ManagementLinks?

done

github-actions · 2024-12-12T21:41:41Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

timja

LGTM, (tested locally)

krisstern

Looks okay to me too!

timja · 2024-12-13T12:05:43Z

Looks like a test is failing consistently on this @janfaracik ?

krisstern · 2024-12-13T12:17:22Z

Yeah, I see the following in the logs:

19:31:19  [INFO] Results:
19:31:19  [INFO] 
19:31:19  [ERROR] Failures: 
19:31:19  [ERROR]   AbstractProjectTest.autoCompleteUpstreamProjects:630->testAutoCompleteResponse:669 
19:31:19  Expected: is <true>
19:31:19       but: was <false>
19:31:19  [INFO] 
19:31:19  [ERROR] Tests run: 2212, Failures: 1, Errors: 0, Skipped: 55
19:31:19  [INFO] 
19:31:19  [ERROR] There are test failures.
19:31:19  
19:31:19  See /home/jenkins/agent/workspace/Core_jenkins_PR-10049/test/target/surefire-reports for the individual test results.

timja · 2024-12-13T16:48:48Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

krisstern · 2024-12-13T18:21:33Z

It looks like we also have a NullPointerException according to the logs at https://github.com/jenkinsci/jenkins/pull/10049/checks?check_run_id=34386281462:

java.lang.NullPointerException: Cannot invoke "org.htmlunit.html.DomElement.getHtmlElementDescendants()" because "doc" is null
	at org.htmlunit.html.HtmlPage.executeDeferredScriptsIfNeeded(HtmlPage.java:1466)
	at org.htmlunit.html.HtmlPage.initialize(HtmlPage.java:265)
	at org.htmlunit.WebClient.loadWebResponseInto(WebClient.java:701)
	at org.htmlunit.WebClient.loadWebResponseInto(WebClient.java:575)
	at org.htmlunit.WebClient.getPage(WebClient.java:493)
	at org.htmlunit.WebClient.getPage(WebClient.java:402)
	at org.htmlunit.WebClient.getPage(WebClient.java:538)
	at org.htmlunit.WebClient.getPage(WebClient.java:520)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.getPage(JenkinsRule.java:2735)
	at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:518)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:676)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:840)

Also one seen at https://ci.jenkins.io/job/Core/job/jenkins/job/PR-10049/7/:

02:14:48  [ERROR]   FileParameterValueTest.fileParameter_canStillUse_internalHierarchy » NullPointer Cannot invoke "org.htmlunit.html.DomElement.getHtmlElementDescendants()" because "doc" is null
02:14:48  [INFO] 
02:14:48  [ERROR] Tests run: 2212, Failures: 0, Errors: 1, Skipped: 55
02:14:48  [INFO] 
02:14:48  [ERROR]

janfaracik and others added 11 commits December 10, 2024 21:37

Refine command palette

cc63c9c

Init

d43a8d3

Update Search.java

24837ea

Revert "Update Search.java"

a9aadba

This reverts commit 24837ea.

Update Search.java

ea67d6a

Merge branch 'master' into refine-command-palette

dad5ef3

Merge branch 'jenkinsci:master' into add-icons-to-command-palette

788ae63

Merge branch 'master' into add-icons-to-command-palette

a3fdb3e

Add support for images

436a02b

Merge branch 'add-icons-to-command-palette' of github.com:janfaracik/…

2357020

…jenkins into add-icons-to-command-palette

Merge branch 'refine-command-palette' into add-icons-to-command-palette

661f994

janfaracik added the web-ui The PR includes WebUI changes which may need special expertise label Dec 11, 2024

Merge branch 'master' into add-icons-to-command-palette

5791010

janfaracik mentioned this pull request Dec 11, 2024

Add icons for search jenkinsci/cloudbees-folder-plugin#450

Merged

3 tasks

timja reviewed Dec 11, 2024

View reviewed changes

core/src/main/java/hudson/model/Computer.java Outdated Show resolved Hide resolved

Implement IconSpec in IComputer

2673844

timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Dec 11, 2024

timja added 2 commits December 11, 2024 21:11

Reword javadoc

d6868c9

Merge branch 'add-icons-to-command-palette' of github.com:janfaracik/…

1b9faa8

…jenkins into add-icons-to-command-palette

Make iconXml private, rename to icon

809d2e6

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Dec 12, 2024

Merge branch 'master' into add-icons-to-command-palette

674d508

janfaracik marked this pull request as ready for review December 13, 2024 09:43

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Dec 13, 2024

timja approved these changes Dec 13, 2024

View reviewed changes

krisstern approved these changes Dec 13, 2024

View reviewed changes

Update AbstractProjectTest.java

e65ce20

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 13, 2024

timja removed the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 13, 2024

janfaracik added 3 commits December 14, 2024 08:51

Trigger Build

b3347e2

Merge branch 'master' into add-icons-to-command-palette

489bdec

Trigger Build

b3d636e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add icons to Command Palette #10049

Add icons to Command Palette #10049

janfaracik commented Dec 11, 2024 •

edited

Loading

Submitter checklist

Maintainer checklist

timja commented Dec 11, 2024

jtnord commented Dec 11, 2024

timja commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

timja left a comment

krisstern left a comment

timja commented Dec 13, 2024

krisstern commented Dec 13, 2024

timja commented Dec 13, 2024

krisstern commented Dec 13, 2024

Add icons to Command Palette #10049

Are you sure you want to change the base?

Add icons to Command Palette #10049

Conversation

janfaracik commented Dec 11, 2024 • edited Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

timja commented Dec 11, 2024

jtnord commented Dec 11, 2024

timja commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

timja left a comment

Choose a reason for hiding this comment

krisstern left a comment

Choose a reason for hiding this comment

timja commented Dec 13, 2024

krisstern commented Dec 13, 2024

timja commented Dec 13, 2024

krisstern commented Dec 13, 2024

janfaracik commented Dec 11, 2024 •

edited

Loading